Bug 141006: Run edit*.cgis in taint mode.

Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave

diff --git a/editcomponents.cgi b/editcomponents.cgi
index f5703666522f05dfd5b77e0f4f54b2185a86eb62..4c00050fa1bcfe69508b44eea0ac6057e70a2066 100755 (executable)
--- a/editcomponents.cgi
+++ b/editcomponents.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public

diff --git a/editmilestones.cgi b/editmilestones.cgi
index e5c8844bd2600a2b6ffead241d90512e7fb8f720..43cded1eac1eb270e959e698c0e76d593aaee319 100755 (executable)
--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 
 #

diff --git a/editparams.cgi b/editparams.cgi
index aaa2b087af4af6f90295a58f196b7a4a6a54a1eb..8ffd76a08ef521368511edf5ecc818063f72231a 100755 (executable)
--- a/editparams.cgi
+++ b/editparams.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public

diff --git a/editproducts.cgi b/editproducts.cgi
index 79fed44115840d89ccdb8f0705ca4588ed371a8c..4fa2cb43df8c0893eef0c7d05b9f6573e80c13f6 100755 (executable)
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public

diff --git a/editusers.cgi b/editusers.cgi
index aa760b1e1e816b40e240d6bc1d025ef389395648..abe4b6194e1c3f3443d7e8f61e372c13f79a13b8 100755 (executable)
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public

diff --git a/editversions.cgi b/editversions.cgi
index 43fe457112141ca149295368b20b8942359264fe..a3a2e2cc5bb4171aff9309286f6c5c5bfdb5684b 100755 (executable)
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public

diff --git a/t/002goodperl.t b/t/002goodperl.t
index 1cfb6a06f25a87172878fcd2babfb47abb989ea8..92a01fc2d19f7e85d5c5e11c9c043ed62f70e1d9 100644 (file)
--- a/t/002goodperl.t
+++ b/t/002goodperl.t
@@ -59,13 +59,8 @@ foreach my $file (@testitems) {
             ok(0, "$file is a module, but has a shebang");
             next;
         } elsif ($ext eq "cgi") {
-            # cgi files must be taint checked, but only the user-accessible
-            # ones have been checked so far
-            if ($file =~ m/^edit/) {
-                $flags = "w";
-            } else {
-                $flags = "wT";
-            }
+            # cgi files must be taint checked
+            $flags = "wT";
         } else {
             ok(0, "$file has shebang but unknown extension");
             next;