]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: stm32: sai: clean up probe error path
authorJohan Hovold <johan@kernel.org>
Mon, 24 Nov 2025 10:49:08 +0000 (11:49 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 25 Nov 2025 16:38:23 +0000 (16:38 +0000)
Use an error label for deregistering also the PCM DMA for consistency.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: olivier moysan <olivier.moysan@foss.st.com>
Link: https://patch.msgid.link/20251124104908.15754-5-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/stm/stm32_sai_sub.c

index 5ae4d2577f28b768df6b366ed5725c7814f6a802..450e1585edeee08561f05cd582427d2bcf2c5e29 100644 (file)
@@ -1716,15 +1716,15 @@ static int stm32_sai_sub_probe(struct platform_device *pdev)
 
        ret = snd_soc_register_component(&pdev->dev, &stm32_component,
                                         &sai->cpu_dai_drv, 1);
-       if (ret) {
-               snd_dmaengine_pcm_unregister(&pdev->dev);
-               goto err_unprepare_pclk;
-       }
+       if (ret)
+               goto err_deregister_pcm_dma;
 
        pm_runtime_enable(&pdev->dev);
 
        return 0;
 
+err_deregister_pcm_dma:
+       snd_dmaengine_pcm_unregister(&pdev->dev);
 err_unprepare_pclk:
        clk_unprepare(sai->pdata->pclk);
        of_node_put(sai->np_sync_provider);