]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: split out virDomainIOMMUDefCheckABIStability
authorJán Tomko <jtomko@redhat.com>
Fri, 12 May 2017 14:59:09 +0000 (16:59 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 15 May 2017 13:44:12 +0000 (15:44 +0200)
src/conf/domain_conf.c

index 25dc8c623106b7db7fbbe9441ecbf23440cb26d5..669860c3ee2f6fec214bf60e6bedbf0d98687679 100644 (file)
@@ -19818,6 +19818,22 @@ virDomainMemoryDefCheckABIStability(virDomainMemoryDefPtr src,
 }
 
 
+static bool
+virDomainIOMMUDefCheckABIStability(virDomainIOMMUDefPtr src,
+                                   virDomainIOMMUDefPtr dst)
+{
+    if (src->model != dst->model) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target domain IOMMU device model '%s' "
+                         "does not match source '%s'"),
+                       virDomainIOMMUModelTypeToString(dst->model),
+                       virDomainIOMMUModelTypeToString(src->model));
+        return false;
+    }
+    return true;
+}
+
+
 static bool
 virDomainDefVcpuCheckAbiStability(virDomainDefPtr src,
                                   virDomainDefPtr dst)
@@ -20284,14 +20300,8 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPtr src,
     }
 
     if (src->iommu &&
-        src->iommu->model != dst->iommu->model) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("Target domain IOMMU device model '%s' "
-                         "does not match source '%s'"),
-                       virDomainIOMMUModelTypeToString(dst->iommu->model),
-                       virDomainIOMMUModelTypeToString(src->iommu->model));
+        !virDomainIOMMUDefCheckABIStability(src->iommu, dst->iommu))
         goto error;
-    }
 
     /* Coverity is not very happy with this - all dead_error_condition */
 #if !STATIC_ANALYSIS