]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
firmware: scmi: Fix setting the function
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 26 Mar 2026 12:08:17 +0000 (15:08 +0300)
committerTom Rini <trini@konsulko.com>
Thu, 9 Apr 2026 18:16:58 +0000 (12:16 -0600)
Set BIT(10) when the function needs to be set, otherwise the setting is
ignored.

Fixes: 0cb160f1b629 ("scmi: pinctrl: add pinctrl driver for SCMI")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/firmware/scmi/pinctrl.c

index 47f7a8ad9b81da50dd665fda876ad7851b8cab17..e670538c87f9bd953f1e290d53de811a27249dc6 100644 (file)
@@ -259,6 +259,8 @@ static int scmi_pinctrl_settings_configure_helper(struct udevice *dev,
        in->attr = 0;
        in->attr |= FIELD_PREP(GENMASK(9, 2), num_configs);
        in->attr |= FIELD_PREP(GENMASK(1, 0), select_type);
+       if (function_id != SCMI_PINCTRL_FUNCTION_NONE)
+               in->attr |= BIT(10);
        memcpy(in->configs, configs, num_configs * sizeof(u32) * 2);
 
        ret = devm_scmi_process_msg(dev, &msg);