]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
use integer division on maxlen
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 10 Jun 2025 21:33:14 +0000 (17:33 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 10 Jun 2025 21:33:36 +0000 (17:33 -0400)
this was coming out as a float and breaking alembic column
compare

Change-Id: I50160cfdb2f2933331d3c316c9985f24fb914242
(cherry picked from commit 61477cf8b8af2b5a7123764a564da056f1a5c999)

lib/sqlalchemy/dialects/mssql/base.py
lib/sqlalchemy/testing/suite/test_reflection.py

index d05dac084ee880c26dbb217e6288535a2d08d93c..368abaf8ffb71888dbddc4ea268b5b8a3c849102 100644 (file)
@@ -3776,7 +3776,7 @@ where
                 MSNChar,
                 MSNText,
             ):
-                kwargs["length"] = maxlen / 2 if maxlen != -1 else None
+                kwargs["length"] = maxlen // 2 if maxlen != -1 else None
                 if collation:
                     kwargs["collation"] = collation
 
index dd126ee8637c93811513daa2cd7f9ba2ae8f2841..12ac5df1c5ef5f56bc5b69e20f4102ad22601de2 100644 (file)
@@ -2870,6 +2870,7 @@ class ComponentReflectionTestExtra(ComparesIndexes, fixtures.TestBase):
             assert isinstance(typ, sql_types.String)
 
         eq_(typ.length, 52)
+        assert isinstance(typ.length, int)
 
     @testing.requires.table_reflection
     def test_nullable_reflection(self, connection, metadata):