]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath11k: use plain access for descriptor length
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 4 Jun 2025 14:34:54 +0000 (16:34 +0200)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 26 Jun 2025 23:10:47 +0000 (16:10 -0700)
The read memory barrier added by commit 6d037a372f81 ("wifi: ath11k: fix
ring-buffer corruption") is enough to guarantee ordering also for plain
descriptor accesses if the length helper is ever inlined so drop the
unnecessary READ_ONCE().

Tested-on: WCN6855 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.41

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Baochen Qiang <quic_bqiang@quicinc.com>
Link: https://patch.msgid.link/20250604143457.26032-3-johan+linaro@kernel.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath11k/hal.c

index 0aa73774150c0aec7b30a2a5ff5acb945ebe250c..4a3bdacc57695d58feb66439b9e09855872929fe 100644 (file)
@@ -601,7 +601,7 @@ u32 ath11k_hal_ce_dst_status_get_length(void *buf)
        struct hal_ce_srng_dst_status_desc *desc = buf;
        u32 len;
 
-       len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, READ_ONCE(desc->flags));
+       len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, desc->flags);
        desc->flags &= ~HAL_CE_DST_STATUS_DESC_FLAGS_LEN;
 
        return len;