]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Add comment explaining annotation (CID #1414431) (#5184)
authorJames Jones <jejones3141@gmail.com>
Thu, 28 Sep 2023 16:31:02 +0000 (11:31 -0500)
committerGitHub <noreply@github.com>
Thu, 28 Sep 2023 16:31:02 +0000 (10:31 -0600)
src/lib/server/pool.c

index 6dd714d57a6b25a0d3e009bc724abf5f2d941ec8..a987860c6a85e34c4ea768bca2fa8963aa1d8c4b 100644 (file)
@@ -1061,6 +1061,12 @@ fr_pool_t *fr_pool_init(TALLOC_CTX *ctx,
                goto error;
        }
 
+       /*
+        *      Coverity notices that other uses of max_pending are protected with a mutex,
+        *      and thus thinks it should be locked/unlocked here...but coverity does not
+        *      consider that until this function returns a pointer to a pool, nobody can
+        *      use the pool, so there's no point to doing so.
+        */
        /* coverity[missing_lock] */
        pool->pending_window = (pool->max_pending > 0) ? pool->max_pending : pool->max;