]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: venus: venc: Make the range of us_per_frame explicit
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 16 Jun 2025 15:29:17 +0000 (15:29 +0000)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 3 Jul 2025 09:02:43 +0000 (11:02 +0200)
Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame.
There is no need to do a 64 bit division here.

Also, the driver only works with whole fps.

Found with cocci:
drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/venus/venc.c

index b9ccee870c3d1238e04cef5e9344bd992d86d737..c0a0ccdded8015bf3c99ab2dff404a64afca8dff 100644 (file)
@@ -412,8 +412,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
        do_div(us_per_frame, timeperframe->denominator);
 
        us_per_frame = clamp(us_per_frame, 1, USEC_PER_SEC);
-       fps = (u64)USEC_PER_SEC;
-       do_div(fps, us_per_frame);
+       fps = USEC_PER_SEC / (u32)us_per_frame;
        fps = min(VENUS_MAX_FPS, fps);
 
        inst->timeperframe = *timeperframe;