]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx334: uninitialized variable in imx334_update_exp_gain()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 30 Apr 2025 08:27:30 +0000 (11:27 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 6 May 2025 11:06:30 +0000 (13:06 +0200)
The "ret" variable is not initialized on the success path.  Set it to
zero.

Fixes: 7b19b0fc8ac8 ("media: i2c: imx334: Convert to CCI register access helpers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/imx334.c

index fc875072f85938d08548e49d79d654dbb8c7c92e..846b9928d4e81d732ef249746a96afc69b79ac58 100644 (file)
@@ -536,7 +536,8 @@ static int imx334_update_controls(struct imx334 *imx334,
 static int imx334_update_exp_gain(struct imx334 *imx334, u32 exposure, u32 gain)
 {
        u32 lpfr, shutter;
-       int ret, ret_hold;
+       int ret_hold;
+       int ret = 0;
 
        lpfr = imx334->vblank + imx334->cur_mode->height;
        shutter = lpfr - exposure;