[3427] Changes after review:

 - variables, test renamed in daemon unit-tests
 - verbose parameter documented in Daemon class

diff --git a/src/lib/dhcpsrv/daemon.h b/src/lib/dhcpsrv/daemon.h
index d14084e37d3fa3b1ef91479911f9f5d60231a10f..eddc7ec371e7f1d4decf0403e5cfcb832cc81b19 100644 (file)
--- a/src/lib/dhcpsrv/daemon.h
+++ b/src/lib/dhcpsrv/daemon.h
@@ -138,6 +138,8 @@ public:
     /// Verbose mode (-v in command-line) triggers loggers to log everythin
     /// (sets severity to DEBUG and debuglevel to 99). Values specified in the
     /// config file are ignored.
+    ///
+    /// @param verbose specifies if verbose should be set or not
     void setVerbose(bool verbose) {
         verbose_ = verbose;
     }

diff --git a/src/lib/dhcpsrv/tests/daemon_unittest.cc b/src/lib/dhcpsrv/tests/daemon_unittest.cc
index 353e5040cef5fb3b15e11d0b39580878b395769c..7e805e5b7a0d4dce39066430b11a7bdc1656bc98 100644 (file)
--- a/src/lib/dhcpsrv/tests/daemon_unittest.cc
+++ b/src/lib/dhcpsrv/tests/daemon_unittest.cc
@@ -27,12 +27,12 @@ namespace {
 
 // Very simple test. Checks whether Daemon can be instantiated and its
 // default parameters are sane
-TEST(DaemonTest, noop) {
-    EXPECT_NO_THROW(Daemon x);
+TEST(DaemonTest, constructor) {
+    EXPECT_NO_THROW(Daemon instance1);
 
     // Check that the verbose mode is not set by default.
-    Daemon y;
-    EXPECT_FALSE(y.getVerbose());
+    Daemon instance2;
+    EXPECT_FALSE(instance2.getVerbose());
 }
 
 // Checks that configureLogger method is behaving properly.