]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: mmp: pxa1908-apbcp: Fix a NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 20 Nov 2024 17:18:44 +0000 (20:18 +0300)
committerStephen Boyd <sboyd@kernel.org>
Tue, 3 Dec 2024 20:01:42 +0000 (12:01 -0800)
The devm_kzalloc() function doesn't return error pointers, it returns
NULL on error.  Update the check to match.

Fixes: a89233dbd4df ("clk: mmp: Add Marvell PXA1908 APBCP driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/6155067d-aed5-4799-9e14-6dff7be1cb3a@stanley.mountain
Acked-by: Duje Mihanović <duje.mihanovic@skole.hr>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/mmp/clk-pxa1908-apbcp.c

index 08f3845cbb1becfa08e82e6e7fd8cb8aac7a0385..f638d7e89b472fccd2672410fbdad4f9325a2d74 100644 (file)
@@ -48,8 +48,8 @@ static int pxa1908_apbcp_probe(struct platform_device *pdev)
        struct pxa1908_clk_unit *pxa_unit;
 
        pxa_unit = devm_kzalloc(&pdev->dev, sizeof(*pxa_unit), GFP_KERNEL);
-       if (IS_ERR(pxa_unit))
-               return PTR_ERR(pxa_unit);
+       if (!pxa_unit)
+               return -ENOMEM;
 
        pxa_unit->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(pxa_unit->base))