]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA: hfi1: simplify hfi1_get_proc_affinity()
authorYury Norov [NVIDIA] <yury.norov@gmail.com>
Wed, 4 Jun 2025 19:39:42 +0000 (15:39 -0400)
committerLeon Romanovsky <leon@kernel.org>
Thu, 26 Jun 2025 09:19:48 +0000 (05:19 -0400)
The function protects the for loop with affinity->num_core_siblings > 0
condition, which is redundant because the loop will break immediately in
that case.

Drop it and save one indentation level.

Signed-off-by: Yury Norov [NVIDIA] <yury.norov@gmail.com>
Link: https://patch.msgid.link/20250604193947.11834-7-yury.norov@gmail.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/hfi1/affinity.c

index 7fa894c23feaf5158633b73e0d21a8ce715af59a..8974aa1e63d1328ac1f6343c15631a638a2205b2 100644 (file)
@@ -1069,22 +1069,20 @@ int hfi1_get_proc_affinity(int node)
         * If HT cores are enabled, identify which HW threads within the
         * physical cores should be used.
         */
-       if (affinity->num_core_siblings > 0) {
-               for (i = 0; i < affinity->num_core_siblings; i++) {
-                       find_hw_thread_mask(i, hw_thread_mask, affinity);
+       for (i = 0; i < affinity->num_core_siblings; i++) {
+               find_hw_thread_mask(i, hw_thread_mask, affinity);
 
-                       /*
-                        * If there's at least one available core for this HW
-                        * thread number, stop looking for a core.
-                        *
-                        * diff will always be not empty at least once in this
-                        * loop as the used mask gets reset when
-                        * (set->mask == set->used) before this loop.
-                        */
-                       cpumask_andnot(diff, hw_thread_mask, &set->used);
-                       if (!cpumask_empty(diff))
-                               break;
-               }
+               /*
+                * If there's at least one available core for this HW
+                * thread number, stop looking for a core.
+                *
+                * diff will always be not empty at least once in this
+                * loop as the used mask gets reset when
+                * (set->mask == set->used) before this loop.
+                */
+               cpumask_andnot(diff, hw_thread_mask, &set->used);
+               if (!cpumask_empty(diff))
+                       break;
        }
        hfi1_cdbg(PROC, "Same available HW thread on all physical CPUs: %*pbl",
                  cpumask_pr_args(hw_thread_mask));