Fix for bug 229998: bugzilla-submit 'Operating-System' and 'URL' fields

are rejected. Minor fixes to bugzilla-submit's argument parsing. Patch
by me, inspired by work done by joseph@picsel.com (Joseph Heenan).
contrib-only. a=myk

diff --git a/contrib/bugzilla-submit/bugdata.txt b/contrib/bugzilla-submit/bugdata.txt
index 56f70b9f1b1aaffe4ad84c79582b05251e73ac36..fc880165cf3948f689d0e40ed79cfb6c187f68c5 100644 (file)
--- a/contrib/bugzilla-submit/bugdata.txt
+++ b/contrib/bugzilla-submit/bugdata.txt
@@ -6,6 +6,8 @@ Hardware: PC
 OS: Linux
 Severity: critical
 Summary: Impending electron shortage
+Depends-on: 8
+URL: http://www.google.com/
 
 We need an emergency supply of electrons.
 

diff --git a/contrib/bugzilla-submit/bugzilla-submit b/contrib/bugzilla-submit/bugzilla-submit
index 0efa501fa0df303391610b4b02118f43878a620a..8d40be04b3abe24fe2e1843a6b51fd38a0724811 100755 (executable)
--- a/contrib/bugzilla-submit/bugzilla-submit
+++ b/contrib/bugzilla-submit/bugzilla-submit
@@ -32,10 +32,10 @@ field_aliases = (('hardware', 'rep_platform'),
                  ('os', 'op_sys'),
                  ('summary', 'short_desc'),
                  ('description', 'comment'),
-                 ('depends-on', 'dependson'),
+                 ('depends_on', 'dependson'),
                  ('status', 'bug_status'),
                  ('severity', 'bug_severity'),
-                 ('URL', 'bug_file_loc'),)
+                 ('url', 'bug_file_loc'),)
 
 def header_to_field(hdr):
     hdr = hdr.lower().replace("-", "_")
@@ -71,7 +71,7 @@ def setup_parser():
     parser.add_option('-H', '--hardware', dest='rep_platform',
                       help='Set the Hardware field.')
     parser.add_option('-o', '--os', dest='op_sys',
-                      help='Set the Operating-system field.')
+                      help='Set the Operating System field.')
     parser.add_option('-r', '--priority', dest='priority',
                       help='Set the Priority field.')
     parser.add_option('-x', '--severity', dest='bug_severity',

diff --git a/contrib/bugzilla-submit/bugzilla-submit.xml b/contrib/bugzilla-submit/bugzilla-submit.xml
index 01ad49e631134977d5fdb11004d9f353f6555935..2ffa9b60102fff91f1b45212c786863bea351cb1 100644 (file)
--- a/contrib/bugzilla-submit/bugzilla-submit.xml
+++ b/contrib/bugzilla-submit/bugzilla-submit.xml
@@ -102,9 +102,10 @@ identifies this field as <quote>Hardware</quote>.)</para></listitem>
 </varlistentry>
 <varlistentry>
 <term>-o, --os</term>
-<listitem><para>Set the op_sys field, overriding the Operating-System header
-from standard input if necessary. (The stock Bugzilla web presentation
-identifies this field as <quote>OS</quote>.)</para></listitem>
+<listitem><para>Set the op_sys field, overriding the OS (Operating
+System) header from standard input if necessary. (The stock Bugzilla web
+presentation also identifies this field as
+<quote>OS</quote>.)</para></listitem>
 </varlistentry>
 <varlistentry>
 <term>-r, --priority</term>