BUG/MEDIUM: log-forward: always quit on parsing errors

The err_code and goto were misplaced, causing a fatal parse error to be
ignored when parsing a UDP listener's address. No backport is needed.

diff --git a/src/log.c b/src/log.c
index 984a31a262d4a23118822fd59e5733a1e1c4689e..5f71bfe35f520f3c0f160fe36abeebecad0c71d4 100644 (file)
--- a/src/log.c
+++ b/src/log.c
@@ -3630,9 +3630,9 @@ int cfg_parse_log_forward(const char *file, int linenum, char **args, int kwm)
                        else {
                                ha_alert("parsing [%s:%d] : '%s %s' : error encountered while parsing listening address %s.\n",
                                         file, linenum, args[0], args[1], args[2]);
-                               err_code |= ERR_ALERT | ERR_FATAL;
-                               goto out;
                        }
+                       err_code |= ERR_ALERT | ERR_FATAL;
+                       goto out;
                }
                list_for_each_entry(l, &bind_conf->listeners, by_bind) {
                        /* Currently, only UDP handlers are allowed */