Validate mime icon URL before allocating store entries

diff --git a/src/mime.cc b/src/mime.cc
index ef610e66df7c58414afe4d42722713be25a94cd4..a159dea369de27457608bc8e95978603765121bc 100644 (file)
--- a/src/mime.cc
+++ b/src/mime.cc
@@ -399,6 +399,10 @@ MimeIcon::created(StoreEntry *newEntry)
         status = Http::scNoContent;
     }
 
+    HttpRequest *r = HttpRequest::CreateFromUrl(url_);
+    if (!r)
+        fatalf("mimeLoadIcon: cannot parse internal URL: %s", url_);
+
     // fill newEntry with a canned 2xx response object
     RequestFlags flags;
     flags.cachable = true;
@@ -407,10 +411,6 @@ MimeIcon::created(StoreEntry *newEntry)
     EBIT_SET(e->flags, ENTRY_SPECIAL);
     e->setPublicKey();
     e->buffer();
-    HttpRequest *r = HttpRequest::CreateFromUrl(url_);
-
-    if (NULL == r)
-        fatalf("mimeLoadIcon: cannot parse internal URL: %s", url_);
 
     e->mem_obj->request = r;
     HTTPMSGLOCK(e->mem_obj->request);