]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Make etype list variables static
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 16 Dec 2021 08:06:55 +0000 (21:06 +1300)
committerJoseph Sutton <jsutton@samba.org>
Mon, 17 Jan 2022 20:05:32 +0000 (20:05 +0000)
If they are not made static, these variables end up being used by the
Kerberos libraries after they have gone out of scope.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/torture/krb5/kdc-heimdal.c

index 14129c6f4634f95c44d31eef7ca87405d5241ec9..93edd994912f160518c565090b2fcd1452f1ca2a 100644 (file)
@@ -791,7 +791,7 @@ static bool torture_krb5_as_req_creds(struct torture_context *tctx,
                break;
 
        case TORTURE_KRB5_TEST_AES: {
-               krb5_enctype etype_list[] = { KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96 };
+               static krb5_enctype etype_list[] = { KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96 };
 
                k5ret = krb5_get_init_creds_opt_alloc(smb_krb5_context->krb5_context,
                                                      &krb_options);
@@ -805,7 +805,7 @@ static bool torture_krb5_as_req_creds(struct torture_context *tctx,
                break;
        }
        case TORTURE_KRB5_TEST_RC4: {
-               krb5_enctype etype_list[] = { KRB5_ENCTYPE_ARCFOUR_HMAC_MD5 };
+               static krb5_enctype etype_list[] = { KRB5_ENCTYPE_ARCFOUR_HMAC_MD5 };
 
                k5ret = krb5_get_init_creds_opt_alloc(smb_krb5_context->krb5_context,
                                                      &krb_options);
@@ -819,8 +819,8 @@ static bool torture_krb5_as_req_creds(struct torture_context *tctx,
                break;
        }
        case TORTURE_KRB5_TEST_AES_RC4: {
-               krb5_enctype etype_list[] = { KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96,
-                                             KRB5_ENCTYPE_ARCFOUR_HMAC_MD5 };
+               static krb5_enctype etype_list[] = { KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96,
+                                                    KRB5_ENCTYPE_ARCFOUR_HMAC_MD5 };
 
                k5ret = krb5_get_init_creds_opt_alloc(smb_krb5_context->krb5_context,
                                                      &krb_options);