Fix so that new versions of system (using clone()) work.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@2253

diff --git a/coregrind/vg_syscalls.c b/coregrind/vg_syscalls.c
index ca6b48e328d8875c352229c51b67939d75403cfe..35e2a18e575208777f91394a8c80b18eaaaf5596 100644 (file)
--- a/coregrind/vg_syscalls.c
+++ b/coregrind/vg_syscalls.c
@@ -2240,7 +2240,9 @@ PRE(clone)
    MAYBE_PRINTF("clone ( %d, %p, %p, %p, %p )\n",arg1,arg2,arg3,arg4,arg5);
 
    if (arg2 == 0 &&
-       arg1 == (VKI_CLONE_CHILD_CLEARTID|VKI_CLONE_CHILD_SETTID|VKI_SIGCHLD)) {
+       (arg1 == (VKI_CLONE_CHILD_CLEARTID|VKI_CLONE_CHILD_SETTID|VKI_SIGCHLD)
+     || arg1 == (VKI_CLONE_PARENT_SETTID|VKI_SIGCHLD))) 
+   {
       before_fork(tid, tst);
       res = VG_(do_syscall)(SYSNO, arg1, arg2, arg3, arg4, arg5);
       after_fork(tid, tst);

diff --git a/none/tests/system.c b/none/tests/system.c
new file mode 100644 (file)
index 0000000..3b906c3
--- /dev/null
+++ b/none/tests/system.c
@@ -0,0 +1,10 @@
+#include <stdlib.h>
+
+// This wasn't working at one point, because glibc used a variant of clone()
+// to implement system(), which Valgrind didn't accept.
+
+int main(void)
+{
+   system("../../tests/true");
+   return 0;
+}

diff --git a/none/tests/system.stderr.exp b/none/tests/system.stderr.exp
new file mode 100644 (file)
index 0000000..139597f
--- /dev/null
+++ b/none/tests/system.stderr.exp
@@ -0,0 +1,2 @@
+
+

diff --git a/none/tests/system.vgtest b/none/tests/system.vgtest
new file mode 100644 (file)
index 0000000..74d9b5b
--- /dev/null
+++ b/none/tests/system.vgtest
@@ -0,0 +1 @@
+prog: system