]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-recoverd: Fix a local memory leak
authorMartin Schwenke <martin@meltin.net>
Mon, 17 Aug 2020 10:27:18 +0000 (20:27 +1000)
committerKarolin Seeger <kseeger@samba.org>
Tue, 25 Aug 2020 11:27:17 +0000 (11:27 +0000)
The memory is allocated off the memory context used by the current
iteration of main loop.  It is freed when main loop completes the fix
doesn't require backporting to stable branches.  However, it is sloppy
so it is worth fixing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14466
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit d2d90f250214582d7124b8137aa2cf5032b2f285)

ctdb/server/ctdb_recoverd.c

index 41f029e6bca5ce7b10c46c608b29dac817853a96..5d6cfa2d0094056ad5543b43fac07e644d8235b9 100644 (file)
@@ -2261,6 +2261,7 @@ static int get_remote_nodemaps(struct ctdb_context *ctdb,
                                        async_getnodemap_callback,
                                        NULL,
                                        remote_nodemaps);
+       talloc_free(nodes);
        return ret;
 }