Don't call FreeLibrary with NULL.

According to the documentation and annotations of FreeLibrary, NULL is
not a legal value to pass. All other calls to FreeLibrary are
correctly handled.

diff --git a/open-vm-tools/lib/misc/machineID.c b/open-vm-tools/lib/misc/machineID.c
index ef73526c32de7aabc9fcc15f701dd42c6c02a2f6..327f1b38c1b6aa4723f12f8cf1445adccb38ce63 100644 (file)
--- a/open-vm-tools/lib/misc/machineID.c
+++ b/open-vm-tools/lib/misc/machineID.c
@@ -142,7 +142,6 @@ ObtainHardwareID(uint64 *hardwareID) // OUT:
 
    // Deal with BUG 21643
    dllHandle = LoadLibrary(TEXT("icmp.dll"));
-   FreeLibrary(dllHandle);
 
    if (!dllHandle) {
       Warning("%s Failed to load icmp.dll.\n", __FUNCTION__);
@@ -150,6 +149,8 @@ ObtainHardwareID(uint64 *hardwareID) // OUT:
       return EINVAL;
    }
 
+   FreeLibrary(dllHandle);
+
    dllHandle = LoadLibrary(TEXT("IpHlpApi.dll"));
 
    if (!dllHandle) {