]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: arm_scmi: use ioread64() instead of ioread64_hi_lo()
authorArnd Bergmann <arnd@arndb.de>
Tue, 4 Mar 2025 14:43:34 +0000 (15:43 +0100)
committerArnd Bergmann <arnd@arndb.de>
Thu, 6 Mar 2025 16:21:38 +0000 (17:21 +0100)
The scmi_common_fastchannel_db_ring() function calls either ioread64()
or ioread64_hi_lo() depending on whether it is compiler for 32-bit
or 64-bit architectures.

The same logic is used to define ioread64() itself in the
linux/io-64-nonatomic-hi-lo.h header file, so the special case
is not really needed.

The behavior here should not change at all.

Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support")
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20250304144346.1025658-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/firmware/arm_scmi/driver.c

index 60050da54bf24c0245290e846f91aea62392855b..1c75a4c9c3716622f6d7f1d81e794db3a45a9a4b 100644 (file)
@@ -1997,17 +1997,7 @@ static void scmi_common_fastchannel_db_ring(struct scmi_fc_db_info *db)
        else if (db->width == 4)
                SCMI_PROTO_FC_RING_DB(32);
        else /* db->width == 8 */
-#ifdef CONFIG_64BIT
                SCMI_PROTO_FC_RING_DB(64);
-#else
-       {
-               u64 val = 0;
-
-               if (db->mask)
-                       val = ioread64_hi_lo(db->addr) & db->mask;
-               iowrite64_hi_lo(db->set | val, db->addr);
-       }
-#endif
 }
 
 /**