]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
vfs: Remove unnecessary list_for_each_entry_safe() from evict_inodes()
authorJan Kara <jack@suse.cz>
Wed, 9 Jul 2025 09:06:36 +0000 (11:06 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 10 Jul 2025 07:37:32 +0000 (09:37 +0200)
evict_inodes() uses list_for_each_entry_safe() to iterate sb->s_inodes
list. However, since we use i_lru list entry for our local temporary
list of inodes to destroy, the inode is guaranteed to stay in
sb->s_inodes list while we hold sb->s_inode_list_lock. So there is no
real need for safe iteration variant and we can use
list_for_each_entry() just fine.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/20250709090635.26319-2-jack@suse.cz
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/inode.c

index a0150e2ef22a322cd6034f9e2b831d6294254eed..01ebdc40021e2d4d70f0a9cb31c373a59f69f62e 100644 (file)
@@ -865,12 +865,12 @@ static void dispose_list(struct list_head *head)
  */
 void evict_inodes(struct super_block *sb)
 {
-       struct inode *inode, *next;
+       struct inode *inode;
        LIST_HEAD(dispose);
 
 again:
        spin_lock(&sb->s_inode_list_lock);
-       list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
+       list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
                if (atomic_read(&inode->i_count))
                        continue;