]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: ufs: Constify the third pwr_change_notify() argument
authorBart Van Assche <bvanassche@acm.org>
Wed, 12 Feb 2025 21:38:02 +0000 (13:38 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 13 Feb 2025 03:25:06 +0000 (22:25 -0500)
The third pwr_change_notify() argument is an input parameter. Make this
explicit by declaring it 'const'.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20250212213838.1044917-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd-priv.h
drivers/ufs/host/ufs-exynos.c
drivers/ufs/host/ufs-exynos.h
drivers/ufs/host/ufs-hisi.c
drivers/ufs/host/ufs-mediatek.c
drivers/ufs/host/ufs-qcom.c
drivers/ufs/host/ufs-sprd.c
drivers/ufs/host/ufshcd-pci.c
include/ufs/ufshcd.h

index 786f20ef22386be20c0f014543fa6930a19ec1fe..2cf500e7444045c9bdcc7911fca7b23e5cada642 100644 (file)
@@ -159,9 +159,9 @@ static inline int ufshcd_vops_link_startup_notify(struct ufs_hba *hba,
 }
 
 static inline int ufshcd_vops_pwr_change_notify(struct ufs_hba *hba,
-                                 enum ufs_notify_change_status status,
-                                 struct ufs_pa_layer_attr *dev_max_params,
-                                 struct ufs_pa_layer_attr *dev_req_params)
+                               enum ufs_notify_change_status status,
+                               const struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
 {
        if (hba->vops && hba->vops->pwr_change_notify)
                return hba->vops->pwr_change_notify(hba, status,
index 13dd5dfc03eb38411e29cde17bba92f0a5c681ff..cab40d0cf1d5e3baccecf26b15417380a5b1e805 100644 (file)
@@ -321,7 +321,7 @@ static int exynosauto_ufs_pre_pwr_change(struct exynos_ufs *ufs,
 }
 
 static int exynosauto_ufs_post_pwr_change(struct exynos_ufs *ufs,
-                                         struct ufs_pa_layer_attr *pwr)
+                                         const struct ufs_pa_layer_attr *pwr)
 {
        struct ufs_hba *hba = ufs->hba;
        u32 enabled_vh;
@@ -396,7 +396,7 @@ static int exynos7_ufs_pre_pwr_change(struct exynos_ufs *ufs,
 }
 
 static int exynos7_ufs_post_pwr_change(struct exynos_ufs *ufs,
-                                               struct ufs_pa_layer_attr *pwr)
+                                      const struct ufs_pa_layer_attr *pwr)
 {
        struct ufs_hba *hba = ufs->hba;
        int lanes = max_t(u32, pwr->lane_rx, pwr->lane_tx);
@@ -813,7 +813,7 @@ static u32 exynos_ufs_get_hs_gear(struct ufs_hba *hba)
 }
 
 static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba,
-                               struct ufs_pa_layer_attr *dev_max_params,
+                               const struct ufs_pa_layer_attr *dev_max_params,
                                struct ufs_pa_layer_attr *dev_req_params)
 {
        struct exynos_ufs *ufs = ufshcd_get_variant(hba);
@@ -865,7 +865,7 @@ out:
 
 #define PWR_MODE_STR_LEN       64
 static int exynos_ufs_post_pwr_mode(struct ufs_hba *hba,
-                               struct ufs_pa_layer_attr *pwr_req)
+                               const struct ufs_pa_layer_attr *pwr_req)
 {
        struct exynos_ufs *ufs = ufshcd_get_variant(hba);
        struct phy *generic_phy = ufs->phy;
@@ -1634,7 +1634,7 @@ static int exynos_ufs_link_startup_notify(struct ufs_hba *hba,
 
 static int exynos_ufs_pwr_change_notify(struct ufs_hba *hba,
                                enum ufs_notify_change_status status,
-                               struct ufs_pa_layer_attr *dev_max_params,
+                               const struct ufs_pa_layer_attr *dev_max_params,
                                struct ufs_pa_layer_attr *dev_req_params)
 {
        int ret = 0;
index 9670dc138d1e49e3c532003fe4306c5a32b8f5a1..aac5172761899a5dd8ad98f9ee34b1671dd27880 100644 (file)
@@ -188,7 +188,7 @@ struct exynos_ufs_drv_data {
        int (*pre_pwr_change)(struct exynos_ufs *ufs,
                                struct ufs_pa_layer_attr *pwr);
        int (*post_pwr_change)(struct exynos_ufs *ufs,
-                               struct ufs_pa_layer_attr *pwr);
+                              const struct ufs_pa_layer_attr *pwr);
        int (*pre_hce_enable)(struct exynos_ufs *ufs);
        int (*post_hce_enable)(struct exynos_ufs *ufs);
 };
index 6e6569de74d8302a6cef78b771e6afb63b244a07..6f2e6bf312253a10f3b83b7c9f699a90aaaee7e0 100644 (file)
@@ -361,9 +361,9 @@ static void ufs_hisi_pwr_change_pre_change(struct ufs_hba *hba)
 }
 
 static int ufs_hisi_pwr_change_notify(struct ufs_hba *hba,
-                                      enum ufs_notify_change_status status,
-                                      struct ufs_pa_layer_attr *dev_max_params,
-                                      struct ufs_pa_layer_attr *dev_req_params)
+                               enum ufs_notify_change_status status,
+                               const struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
 {
        struct ufs_host_params host_params;
        int ret = 0;
index 135cd78109e24e47e3bfab78434650ae90de4376..927c0bcdb9a96ba232a766682c0c11c0d3473391 100644 (file)
@@ -1081,8 +1081,8 @@ static bool ufs_mtk_pmc_via_fastauto(struct ufs_hba *hba,
 }
 
 static int ufs_mtk_pre_pwr_change(struct ufs_hba *hba,
-                                 struct ufs_pa_layer_attr *dev_max_params,
-                                 struct ufs_pa_layer_attr *dev_req_params)
+                               const struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
 {
        struct ufs_mtk_host *host = ufshcd_get_variant(hba);
        struct ufs_host_params host_params;
@@ -1134,9 +1134,9 @@ static int ufs_mtk_pre_pwr_change(struct ufs_hba *hba,
 }
 
 static int ufs_mtk_pwr_change_notify(struct ufs_hba *hba,
-                                    enum ufs_notify_change_status stage,
-                                    struct ufs_pa_layer_attr *dev_max_params,
-                                    struct ufs_pa_layer_attr *dev_req_params)
+                               enum ufs_notify_change_status stage,
+                               const struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
 {
        int ret = 0;
 
index e69b792523e600e27d5a1046a7a6439d50283207..45eabccdfa31698a98c916aa788c07512c004e60 100644 (file)
@@ -807,7 +807,7 @@ static int ufs_qcom_icc_update_bw(struct ufs_qcom_host *host)
 
 static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
                                enum ufs_notify_change_status status,
-                               struct ufs_pa_layer_attr *dev_max_params,
+                               const struct ufs_pa_layer_attr *dev_max_params,
                                struct ufs_pa_layer_attr *dev_req_params)
 {
        struct ufs_qcom_host *host = ufshcd_get_variant(hba);
index b1d532363f9d490b3415cc1b9d98604c8ddf44cd..65bd8fb96b995ca11e6cf0dee227d2e80ac40d84 100644 (file)
@@ -160,9 +160,9 @@ static int ufs_sprd_common_init(struct ufs_hba *hba)
 }
 
 static int sprd_ufs_pwr_change_notify(struct ufs_hba *hba,
-                                     enum ufs_notify_change_status status,
-                                     struct ufs_pa_layer_attr *dev_max_params,
-                                     struct ufs_pa_layer_attr *dev_req_params)
+                               enum ufs_notify_change_status status,
+                               const struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
 {
        struct ufs_sprd_host *host = ufshcd_get_variant(hba);
 
index ea39c5d5b8cf15c3e9f121c221955cb8e8de560b..2245397a9cc2090d2b62d617607477ae4d677415 100644 (file)
@@ -157,7 +157,7 @@ static int ufs_intel_set_lanes(struct ufs_hba *hba, u32 lanes)
 
 static int ufs_intel_lkf_pwr_change_notify(struct ufs_hba *hba,
                                enum ufs_notify_change_status status,
-                               struct ufs_pa_layer_attr *dev_max_params,
+                               const struct ufs_pa_layer_attr *dev_max_params,
                                struct ufs_pa_layer_attr *dev_req_params)
 {
        int err = 0;
index 5efa570de4c155fdee69aa9bf87b8c8ab3fcd2cf..34221146410e34ce264da18c861fb17b3ff940f3 100644 (file)
@@ -353,9 +353,9 @@ struct ufs_hba_variant_ops {
        int     (*link_startup_notify)(struct ufs_hba *,
                                       enum ufs_notify_change_status);
        int     (*pwr_change_notify)(struct ufs_hba *,
-                               enum ufs_notify_change_status status,
-                               struct ufs_pa_layer_attr *desired_pwr_mode,
-                               struct ufs_pa_layer_attr *final_params);
+                       enum ufs_notify_change_status status,
+                       const struct ufs_pa_layer_attr *desired_pwr_mode,
+                       struct ufs_pa_layer_attr *final_params);
        void    (*setup_xfer_req)(struct ufs_hba *hba, int tag,
                                  bool is_scsi_cmd);
        void    (*setup_task_mgmt)(struct ufs_hba *, int, u8);
@@ -1429,7 +1429,7 @@ static inline int ufshcd_dme_peer_get(struct ufs_hba *hba,
        return ufshcd_dme_get_attr(hba, attr_sel, mib_val, DME_PEER);
 }
 
-static inline bool ufshcd_is_hs_mode(struct ufs_pa_layer_attr *pwr_info)
+static inline bool ufshcd_is_hs_mode(const struct ufs_pa_layer_attr *pwr_info)
 {
        return (pwr_info->pwr_rx == FAST_MODE ||
                pwr_info->pwr_rx == FASTAUTO_MODE) &&