]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwspinlock: omap: Handle devm_pm_runtime_enable() errors
authorHaotian Zhang <vulab@iscas.ac.cn>
Mon, 24 Nov 2025 10:48:05 +0000 (18:48 +0800)
committerKevin Hilman <khilman@baylibre.com>
Wed, 14 Jan 2026 22:36:55 +0000 (14:36 -0800)
Although unlikely, devm_pm_runtime_enable() can fail due to memory
allocations. Without proper error handling, the subsequent
pm_runtime_resume_and_get() call may operate on incorrectly
initialized runtime PM state.

Add error handling to check the return value of
devm_pm_runtime_enable() and return on failure.

Fixes: 25f7d74d4514 ("hwspinlock: omap: Use devm_pm_runtime_enable() helper")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251124104805.135-1-vulab@iscas.ac.cn
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
drivers/hwspinlock/omap_hwspinlock.c

index 27b47b8623c09cca9c3d8da8cd6bf38f27f28f14..2d8de835bc24298266a5c14fe62b88a7e5a39bc6 100644 (file)
@@ -88,7 +88,9 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
         * make sure the module is enabled and clocked before reading
         * the module SYSSTATUS register
         */
-       devm_pm_runtime_enable(&pdev->dev);
+       ret = devm_pm_runtime_enable(&pdev->dev);
+       if (ret)
+               return ret;
        ret = pm_runtime_resume_and_get(&pdev->dev);
        if (ret < 0)
                return ret;