Bug 193575 - Internal server error from votes.cgi

patch by bugzilla@chimpychompy.org (GavinS)
r=bbaetz, a=justdave

diff --git a/votes.cgi b/votes.cgi
index 1c7bc78166ff234ffcf05ba51438f823e87e3a2e..dfa55b91d6c24e9112e3b21a790e351429ac6b98 100755 (executable)
--- a/votes.cgi
+++ b/votes.cgi
@@ -135,7 +135,8 @@ sub show_user {
     # special error handling should go away.
     $who || ThrowUserError("invalid_username", {name => $name});
     
-    my $canedit = 1 if ($name eq Bugzilla->user->login);
+    my $canedit = 1 if (Bugzilla->user &&
+                        $name eq Bugzilla->user->login);
     
     SendSQL("LOCK TABLES bugs READ, products READ, votes WRITE,
              cc READ, bug_group_map READ, user_group_map READ,
@@ -200,6 +201,10 @@ sub show_user {
                            opened => IsOpenedState($status) });
         }
         
+        # In case we didn't populate this earlier (i.e. an error, or
+        # a not logged in user viewing a users votes)
+        $maxvotesperbug{$product} ||= 0;
+
         $onevoteonly = 1 if (min($::prodmaxvotes{$product},
                                  $maxvotesperbug{$product}) == 1);