]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: atomisp: gc0310: Drop gc0310_get_frame_interval()
authorHans de Goede <hansg@kernel.org>
Sat, 17 May 2025 11:41:04 +0000 (13:41 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 8 Jul 2025 06:43:32 +0000 (08:43 +0200)
On raw camera sensors the framerate is controlled through vblank
(and optional) hblank controls.

Having a get_frame_interval makes no sense in this case, drop it.

Signed-off-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20250517114106.43494-22-hansg@kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

index 173ddf41ad4771feb5eea4f6180c0ce046e6ae58..956d3213d19883ca079c617022118c50ee498d5e 100644 (file)
@@ -498,23 +498,6 @@ static int gc0310_disable_streams(struct v4l2_subdev *sd,
        return ret;
 }
 
-static int gc0310_get_frame_interval(struct v4l2_subdev *sd,
-                                    struct v4l2_subdev_state *sd_state,
-                                    struct v4l2_subdev_frame_interval *interval)
-{
-       /*
-        * FIXME: Implement support for V4L2_SUBDEV_FORMAT_TRY, using the V4L2
-        * subdev active state API.
-        */
-       if (interval->which != V4L2_SUBDEV_FORMAT_ACTIVE)
-               return -EINVAL;
-
-       interval->interval.numerator = 1;
-       interval->interval.denominator = GC0310_FPS;
-
-       return 0;
-}
-
 static int gc0310_enum_mbus_code(struct v4l2_subdev *sd,
                                 struct v4l2_subdev_state *sd_state,
                                 struct v4l2_subdev_mbus_code_enum *code)
@@ -564,7 +547,6 @@ static const struct v4l2_subdev_pad_ops gc0310_pad_ops = {
        .set_fmt = v4l2_subdev_get_fmt, /* Only 1 fixed mode supported */
        .get_selection = gc0310_get_selection,
        .set_selection = gc0310_get_selection,
-       .get_frame_interval = gc0310_get_frame_interval,
        .enable_streams = gc0310_enable_streams,
        .disable_streams = gc0310_disable_streams,
 };