]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetStatsBlockExportHeader: Remove return value
authorPeter Krempa <pkrempa@redhat.com>
Mon, 17 Feb 2025 10:19:11 +0000 (11:19 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 20 Feb 2025 14:15:39 +0000 (15:15 +0100)
The function always returns 0. Remove return value and fix callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 877fefaa38b9420416660dc054bfc29a09a33064..174dad64b0614db2d062f411ce1d349cd832d7da 100644 (file)
@@ -17365,7 +17365,7 @@ qemuDomainGetStatsBlockExportHeader(virDomainDiskDef *disk,
 }
 
 
-static int
+static void
 qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
                                   GHashTable *stats,
                                   virTypedParamList *params,
@@ -17391,7 +17391,7 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
 
         (*recordnr)++;
 
-        return 0;
+        return;
     }
 
     /* vhost-user disk doesn't support getting block stats */
@@ -17400,7 +17400,7 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
 
         (*recordnr)++;
 
-        return 0;
+        return;
     }
 
     for (n = disk->src; virStorageSourceIsBacking(n); n = n->backingStore) {
@@ -17494,8 +17494,6 @@ qemuDomainGetStatsBlockExportDisk(virDomainDiskDef *disk,
             }
         }
     }
-
-    return 0;
 }
 
 
@@ -17530,10 +17528,8 @@ qemuDomainGetStatsBlock(virQEMUDriver *driver,
     }
 
     for (i = 0; i < dom->def->ndisks; i++) {
-        if (qemuDomainGetStatsBlockExportDisk(dom->def->disks[i], stats,
-                                              blockparams, &visited,
-                                              visitBacking, cfg, dom) < 0)
-            return -1;
+        qemuDomainGetStatsBlockExportDisk(dom->def->disks[i], stats, blockparams,
+                                          &visited, visitBacking, cfg, dom);
     }
 
     virTypedParamListAddUInt(params, visited, "block.count");