ALSA: usb-audio: qcom: clear opened when stream enable fails

On enable, subs->opened is set before the service_interval is validated;
an invalid interval jumps to the response label without clearing it, so
the substream is wedged at -EBUSY until a disable or disconnect.

Clear subs->opened on the enable error path.

Fixes: 326bbc348298a ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com>
Link: https://patch.msgid.link/20260618025126.1862954-3-michael.bommarito@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index 3b05dadbbeae29e9674cc1df8ff0f50ff471e6cc..3a586fd16e7297fd5c4f391ea8f1f428d934ddc1 100644 (file)
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c
@@ -1620,8 +1620,13 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle,
        if (req_msg->service_interval_valid) {
                ret = get_data_interval_from_si(subs,
                                                req_msg->service_interval);
-               if (ret == -EINVAL)
+               if (ret == -EINVAL) {
+                       if (req_msg->enable) {
+                               guard(mutex)(&chip->mutex);
+                               subs->opened = 0;
+                       }
                        goto response;
+               }
 
                datainterval = ret;
        }