method: Check with same rules for dbus compatibility as in GBusModule

Only issue warning if the method would actually be end up on DBus as
per generate_interface_method_call_function() or get_method_info().

Based on patch by Corentin Noël

https://bugzilla.gnome.org/show_bug.cgi?id=793859

diff --git a/vala/valamethod.vala b/vala/valamethod.vala
index 133bca52e17d68ab19605efa1e2a4f0250c680a4..a2bd57c45ed6a9cf2e95a3463b78aaedc8b1532a 100644 (file)
--- a/vala/valamethod.vala
+++ b/vala/valamethod.vala
@@ -857,7 +857,9 @@ public class Vala.Method : Subroutine, Callable {
                }
 
                // check that DBus methods at least throw "GLib.Error" or "GLib.DBusError, GLib.IOError"
-               if (parent_symbol is ObjectTypeSymbol && parent_symbol.get_attribute ("DBus") != null) {
+               if (!(this is CreationMethod) && binding == MemberBinding.INSTANCE
+                   && !overrides && access == SymbolAccessibility.PUBLIC
+                   && parent_symbol is ObjectTypeSymbol && parent_symbol.get_attribute ("DBus") != null) {
                        Attribute? dbus_attr = get_attribute ("DBus");
                        if (dbus_attr == null || dbus_attr.get_bool ("visible", true)) {
                                bool throws_gerror = false;