]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
src: fix resource leak introduced in d4439a6b8
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Thu, 7 Jan 2021 13:09:19 +0000 (16:09 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Thu, 7 Jan 2021 15:39:12 +0000 (18:39 +0300)
@tmp that was copied just above is leaked on plain return.
The issue is found by Coverity.

Patch that inroduced a leak:
d4439a6b8 : src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/libvirt-domain.c

index 2f9081a877c192d0874abf25ea1e0102f9ce7fb4..c9f8ffdb56f1ddb55c4d2b9a7ee29e7c0ffe4c3e 100644 (file)
@@ -3022,7 +3022,7 @@ virDomainMigrateVersion3Full(virDomainPtr domain,
     ret = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn,
                                    VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION);
     if (ret < 0)
-        return NULL;
+        goto done;
     if (ret)
         protection = VIR_MIGRATE_CHANGE_PROTECTION;