]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
authorLiang He <windhl@126.com>
Wed, 22 Mar 2023 04:16:57 +0000 (12:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:11:07 +0000 (23:11 +0900)
[ Upstream commit dc70234c408c644505a24362b0f095f713e4697e ]

In cros_typec_register_switches(), we should add fwnode_handle_put()
when break out of the iteration device_for_each_child_node()
as it will automatically increase and decrease the refcounter.

Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20230322041657.1857001-1-windhl@126.com
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/chrome/cros_typec_switch.c

index a26219e97c931f6510417df43cafa9762ff06f9f..26af51952f7f1e6429f975ffa747ce846545b7f2 100644 (file)
@@ -268,6 +268,7 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata)
 
        return 0;
 err_switch:
+       fwnode_handle_put(fwnode);
        cros_typec_unregister_switches(sdata);
        return ret;
 }