]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
return "true", not pointer. CID 1469178
authorAlan T. DeKok <aland@freeradius.org>
Wed, 11 Nov 2020 17:58:54 +0000 (12:58 -0500)
committerAlan T. DeKok <aland@freeradius.org>
Wed, 11 Nov 2020 20:42:32 +0000 (15:42 -0500)
src/modules/rlm_csv/rlm_csv.c

index f9a839491cf52716d7e9194917262132cdb5ed04..c49fe726b76468e23f8ee3dc446c8f7f1f53ab73 100644 (file)
@@ -189,6 +189,8 @@ static bool insert_entry(CONF_SECTION *conf, rlm_csv_t *inst, rlm_csv_entry_t *e
 {
        rlm_csv_entry_t *old;
 
+       fr_assert(e != NULL);
+
        old = find_entry(inst, e->key);
        if (old) {
                if (!inst->allow_multiple_keys && !inst->multiple_index_fields) {
@@ -202,7 +204,7 @@ static bool insert_entry(CONF_SECTION *conf, rlm_csv_t *inst, rlm_csv_entry_t *e
                 */
                while (old->next) old = old->next;
                old->next = e;
-               return e;
+               return true;
        }
 
        if ((inst->key_data_type == FR_TYPE_IPV4_ADDR) || (inst->key_data_type == FR_TYPE_IPV4_PREFIX)) {