Remove sandbox verb from needs_build()

It's not a clear cut case whether the sandbox needs a build or not.
The needs_build() method was originally intended for verbs that need
a full image build but the sandbox build only needs the tools tree.
Also, the tools tree is only built if ToolsTree=default and not if
set explicitly.

More practically, we don't want the JSON history from .mkosi-private
to be used when using mkosi sandbox, and that's the only usage of
the needs_build() method, so to fix that problem let's remove the sandbox
verb from needs_build().

diff --git a/mkosi/__init__.py b/mkosi/__init__.py
index dfc59d27d0699a2d73bdcb50f0cf05e0dbf690e3..afcc21b00416800cfd8fb68490ab2511ab04579f 100644 (file)
--- a/mkosi/__init__.py
+++ b/mkosi/__init__.py
@@ -4596,7 +4596,7 @@ def run_verb(args: Args, images: Sequence[Config], *, resources: Path) -> None:
 
         return
 
-    assert args.verb.needs_build()
+    assert args.verb == Verb.sandbox or args.verb.needs_build()
 
     if (
         tools

diff --git a/mkosi/config.py b/mkosi/config.py
index 75bdb140193d7cea3b60eddf4dcd372c9f146c6f..0d09ce2da908fa4352a96de088b8ade9b8c76fd5 100644 (file)
--- a/mkosi/config.py
+++ b/mkosi/config.py
@@ -104,7 +104,6 @@ class Verb(StrEnum):
             Verb.serve,
             Verb.burn,
             Verb.sysupdate,
-            Verb.sandbox,
         )
 
     def needs_config(self) -> bool: