]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
Napatech: Fix network byte order when comparing addresses
authorPhil Young <py@napatech.com>
Mon, 1 Jun 2020 15:02:49 +0000 (11:02 -0400)
committerVictor Julien <victor@inliniac.net>
Wed, 3 Jun 2020 11:36:55 +0000 (13:36 +0200)
This fixes an issue where the "endieness" was not properly accounted for
when comparing two IPv4 addresses to be sorted.

src/source-napatech.c

index e3416cbb74050182bea7c0e39836cc8c1a1ff198..3eab47a74f54a2e611eb11644a0939137f7bc2d2 100644 (file)
@@ -457,7 +457,7 @@ static int ProgramFlow(Packet *p, int is_inline)
                 v4Tuple.sa = pIPv4_hdr->src_addr;
                 v4Tuple.da = pIPv4_hdr->dst_addr;
             } else {
-                do_swap = (pIPv4_hdr->src_addr > pIPv4_hdr->dst_addr);
+                do_swap = (htonl(pIPv4_hdr->src_addr) > htonl(pIPv4_hdr->dst_addr));
                 if (!do_swap) {
                     /* already in order */
                     v4Tuple.sa = pIPv4_hdr->src_addr;