]> git.ipfire.org Git - thirdparty/valgrind.git/commitdiff
macOS: Don't duplicate -fno-stack-protector
authorRhys Kidd <rhyskidd@gmail.com>
Sat, 2 Feb 2019 23:22:16 +0000 (18:22 -0500)
committerRhys Kidd <rhyskidd@gmail.com>
Mon, 11 Mar 2019 11:49:37 +0000 (22:49 +1100)
Since f38d96d -fno-stack-protector has been added to $(AM_CFLAGS_BASE) on all
platforms, if the compiler supports it. Accordingly, there's no need to still add
this a second time specifically for macOS.

Fixes: f38d96d ("Add -Wformat -Wformat-security to the list of compile flags.")
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
Makefile.all.am

index 2ad54034f0918059b6f1e6993b5f42a216f826f8..daa7e413f8f0b2eb43a2a6326510e8377a23bca5 100644 (file)
@@ -222,14 +222,14 @@ AM_CCASFLAGS_ARM64_LINUX  = @FLAG_M64@ -g
 AM_FLAG_M3264_X86_DARWIN = -arch i386
 AM_CFLAGS_X86_DARWIN     = $(WERROR) -arch i386 $(AM_CFLAGS_BASE) \
                                -mmacosx-version-min=10.6 \
-                               -fno-stack-protector -fno-pic -fno-PIC
+                               -fno-pic -fno-PIC
 
 AM_CFLAGS_PSO_X86_DARWIN = $(AM_CFLAGS_X86_DARWIN) $(AM_CFLAGS_PSO_BASE)
 AM_CCASFLAGS_X86_DARWIN  = -arch i386 -g
 
 AM_FLAG_M3264_AMD64_DARWIN = -arch x86_64
 AM_CFLAGS_AMD64_DARWIN     = $(WERROR) -arch x86_64 $(AM_CFLAGS_BASE) \
-                           -mmacosx-version-min=10.6 -fno-stack-protector
+                           -mmacosx-version-min=10.6
 AM_CFLAGS_PSO_AMD64_DARWIN = $(AM_CFLAGS_AMD64_DARWIN) $(AM_CFLAGS_PSO_BASE)
 AM_CCASFLAGS_AMD64_DARWIN  = -arch x86_64 -g