]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Work around setuptools issue #1902
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 8 Nov 2019 14:48:27 +0000 (09:48 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 8 Nov 2019 16:25:05 +0000 (11:25 -0500)
Added a workaround for a setuptools-related failure that has been observed
as occurring on Windows installations, where setuptools is not correctly
reporting a build error when the MSVC build dependencies are not installed
and therefore not allowing graceful degradation into non C extensions
builds.

Setuptools issue https://github.com/pypa/setuptools/issues/1902

Fixes: #4967
Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e
(cherry picked from commit 4a2dd4902a1168234f14bdd0634728086d53c406)

doc/build/changelog/unreleased_13/4967.rst [new file with mode: 0644]
setup.py

diff --git a/doc/build/changelog/unreleased_13/4967.rst b/doc/build/changelog/unreleased_13/4967.rst
new file mode 100644 (file)
index 0000000..341c572
--- /dev/null
@@ -0,0 +1,9 @@
+.. change::
+    :tags: bug, installation, windows
+    :tickets: 4967
+
+    Added a workaround for a setuptools-related failure that has been observed
+    as occurring on Windows installations, where setuptools is not correctly
+    reporting a build error when the MSVC build dependencies are not installed
+    and therefore not allowing graceful degradation into non C extensions
+    builds.
index e0351452344bcc217e26ff27614d872921799565..9f39dfee34cc9c3b1c19c610f2fd2b6a132315cc 100644 (file)
--- a/setup.py
+++ b/setup.py
@@ -38,7 +38,8 @@ ext_errors = (CCompilerError, DistutilsExecError, DistutilsPlatformError)
 if sys.platform == "win32":
     # 2.6's distutils.msvc9compiler can raise an IOError when failing to
     # find the compiler
-    ext_errors += (IOError,)
+    # for TypeError, see https://github.com/pypa/setuptools/issues/1902
+    ext_errors += (IOError, TypeError)
 
 
 class BuildFailed(Exception):