]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu/mmhub4.1.0: add bounds checking for cid
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 4 Mar 2026 22:25:56 +0000 (17:25 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Mar 2026 16:19:11 +0000 (12:19 -0400)
The value should never exceed the array size as those
are the only values the hardware is expected to return,
but add checks anyway.

Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 04f063d85090f5dd0c671010ce88ee49d9dcc8ed)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c

index 951998454b257294388bc41e01b2c19d87060688..88bfe321f83aaa2af039ebb5fea084940d3600f7 100644 (file)
@@ -102,7 +102,8 @@ mmhub_v4_1_0_print_l2_protection_fault_status(struct amdgpu_device *adev,
                status);
        switch (amdgpu_ip_version(adev, MMHUB_HWIP, 0)) {
        case IP_VERSION(4, 1, 0):
-               mmhub_cid = mmhub_client_ids_v4_1_0[cid][rw];
+               mmhub_cid = cid < ARRAY_SIZE(mmhub_client_ids_v4_1_0) ?
+                       mmhub_client_ids_v4_1_0[cid][rw] : NULL;
                break;
        default:
                mmhub_cid = NULL;