]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytest: dns_aging: remove/fix unused helper functions
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 14 Jun 2021 11:30:23 +0000 (23:30 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 20 Jun 2021 23:26:32 +0000 (23:26 +0000)
self.rpc_delete_txt() will be used next commit.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/dns_aging.py

index e826817c55791e694f310e0c236c0f35e7855920..d196fa1a65c9f815d861bac2ea3cc270de5f7828 100644 (file)
@@ -243,14 +243,6 @@ class TestDNSAging(DNSTest):
         except WERRORError as e:
             self.fail(f"could not replace record ({e})")
 
-    def rpc_add(self, name, data, wtype):
-        rec_buf = recbuf_from_string(wtype, data)
-        self.rpc_replace(name, None, rec_buf)
-
-    def rpc_delete(self, name, data, wtype):
-        rec_buf = recbuf_from_string(wtype, data)
-        self.rpc_replace(name, rec_buf, None)
-
     def get_unique_txt_record(self, name, txt):
         """Get the TXT record on Name with value txt, asserting that there is
         only one."""
@@ -376,6 +368,12 @@ class TestDNSAging(DNSTest):
 
         return self.get_unique_txt_record(name, txt)
 
+    def rpc_delete_txt(self, name, txt):
+        if isinstance(txt, str):
+            txt = [txt]
+        old = TXTRecord(txt)
+        self.rpc_replace(name, old, None)
+
     def get_one_node(self, name):
         expr = f"(&(objectClass=dnsNode)(name={name}))"
         nodes = self.samdb.search(base=self.zone_dn,