Test fixture improvements

- ensure we escape out percent signs when a CompiledSQL or RegexSQL
has percent signs in the SQL or in the parameter repr

- to support combinations, print out complete test name in skip
messages, py.test environment gives us a way to do this

Change-Id: Ia9e62f7c1026c1465986144c5757e35fc164a2b8

diff --git a/lib/sqlalchemy/testing/assertsql.py b/lib/sqlalchemy/testing/assertsql.py
index 6a654df1ece3a8d45b12cc3d9c92b435a98e6a78..3a8f459185a5a6989cfbdf9d84c535571b220737 100644 (file)
--- a/lib/sqlalchemy/testing/assertsql.py
+++ b/lib/sqlalchemy/testing/assertsql.py
@@ -182,10 +182,13 @@ class CompiledSQL(SQLMatchRule):
 
     def _failure_message(self, expected_params):
         return (
-            "Testing for compiled statement %r partial params %r, "
+            "Testing for compiled statement %r partial params %s, "
             "received %%(received_statement)r with params "
             "%%(received_parameters)r"
-            % (self.statement.replace("%", "%%"), expected_params)
+            % (
+                self.statement.replace("%", "%%"),
+                repr(expected_params).replace("%", "%%"),
+            )
         )
 
 
@@ -199,9 +202,13 @@ class RegexSQL(CompiledSQL):
 
     def _failure_message(self, expected_params):
         return (
-            "Testing for compiled statement ~%r partial params %r, "
+            "Testing for compiled statement ~%r partial params %s, "
             "received %%(received_statement)r with params "
-            "%%(received_parameters)r" % (self.orig_regex, expected_params)
+            "%%(received_parameters)r"
+            % (
+                self.orig_regex.replace("%", "%%"),
+                repr(expected_params).replace("%", "%%"),
+            )
         )
 
     def _compare_sql(self, execute_observed, received_statement):

diff --git a/lib/sqlalchemy/testing/config.py b/lib/sqlalchemy/testing/config.py
index 8262142ec5a0c6a8df35ddf3a67a5fac6a17838d..ae84a7878cc7e42544f57fe2fe422cd4dc02f4f6 100644 (file)
--- a/lib/sqlalchemy/testing/config.py
+++ b/lib/sqlalchemy/testing/config.py
@@ -89,6 +89,10 @@ def fixture(*arg, **kw):
     return _fixture_functions.fixture(*arg, **kw)
 
 
+def get_current_test_name():
+    return _fixture_functions.get_current_test_name()
+
+
 class Config(object):
     def __init__(self, db, db_opts, options, file_config):
         self._set_name(db)

diff --git a/lib/sqlalchemy/testing/exclusions.py b/lib/sqlalchemy/testing/exclusions.py
index 86f3b7aacd4ef3ebf35ac979440705cc4db1e0a0..97cee7e2770e84d4482429ee0c89aa50d170b68f 100644 (file)
--- a/lib/sqlalchemy/testing/exclusions.py
+++ b/lib/sqlalchemy/testing/exclusions.py
@@ -141,7 +141,10 @@ class compound(object):
 
         for skip in self.skips:
             if self._check_combinations(combination, skip) and skip(cfg):
-                msg = "'%s' : %s" % (fn.__name__, skip._as_string(cfg))
+                msg = "'%s' : %s" % (
+                    config.get_current_test_name(),
+                    skip._as_string(cfg),
+                )
                 config.skip_test(msg)
 
         try:

diff --git a/lib/sqlalchemy/testing/plugin/plugin_base.py b/lib/sqlalchemy/testing/plugin/plugin_base.py
index be1984c9e08406e87c2876e92b5d8bf1e08fe077..33967ec156edf7b5c3adb15e2f36a52686da0e6d 100644 (file)
--- a/lib/sqlalchemy/testing/plugin/plugin_base.py
+++ b/lib/sqlalchemy/testing/plugin/plugin_base.py
@@ -730,6 +730,9 @@ class FixtureFunctions(ABC):
     def fixture(self, *arg, **kw):
         raise NotImplementedError()
 
+    def get_current_test_name(self):
+        raise NotImplementedError()
+
 
 _fixture_fn_class = None
 

diff --git a/lib/sqlalchemy/testing/plugin/pytestplugin.py b/lib/sqlalchemy/testing/plugin/pytestplugin.py
index 2f7df97fa6ffd2695e7c8886db7e7513c6bb71b9..44fccf28df609e9e111e5e2b890507627bc685b2 100644 (file)
--- a/lib/sqlalchemy/testing/plugin/pytestplugin.py
+++ b/lib/sqlalchemy/testing/plugin/pytestplugin.py
@@ -412,3 +412,6 @@ class PytestFixtureFunctions(plugin_base.FixtureFunctions):
 
     def fixture(self, *arg, **kw):
         return pytest.fixture(*arg, **kw)
+
+    def get_current_test_name(self):
+        return os.environ.get("PYTEST_CURRENT_TEST")