]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
"misdn show config" segfaults asterisk, if no MSN lists
authorDavid Vossel <dvossel@digium.com>
Fri, 8 May 2009 14:51:09 +0000 (14:51 +0000)
committerDavid Vossel <dvossel@digium.com>
Fri, 8 May 2009 14:51:09 +0000 (14:51 +0000)
(closes issue #14976)
Reported by: alecdavis
Patches:
      misdn_config.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, FabienToune

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@193262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

channels/misdn_config.c

index e16b8fd85f99a9615d1dd07741333e4868e536e7..71f54adcc549c9eff880fc74e4b6e8459aef4c66 100644 (file)
@@ -798,7 +798,9 @@ void misdn_cfg_get_config_string (int port, enum misdn_cfg_elements elem, char*
                                for (; iter; iter = iter->next) {
                                        strncat(tempbuf, iter->msn, sizeof(tempbuf) - strlen(tempbuf) - 1);
                                }
-                               tempbuf[strlen(tempbuf)-2] = 0;
+                               if (strlen(tempbuf) > 1) {
+                                       tempbuf[strlen(tempbuf)-2] = 0;
+                               }
                        }
                        snprintf(buf, bufsize, " -> msns: %s", *tempbuf ? tempbuf : "none");
                        break;