]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Fix segfault of snapshot-list
authorOsier Yang <jyang@redhat.com>
Mon, 22 Oct 2012 14:28:59 +0000 (22:28 +0800)
committerCole Robinson <crobinso@redhat.com>
Sat, 27 Oct 2012 19:11:48 +0000 (15:11 -0400)
'snaps' is used after free()'ed.
(cherry picked from commit e0ad4669834d44763f7201ae97b997e9c64e8940)

tools/virsh-snapshot.c

index b82837116ea22803549d1e91d6c519e08e39ef39..53de2b3addf8a4f3470e5c623acf7d0b79cd6c64 100644 (file)
@@ -866,7 +866,7 @@ vshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
                     goto cleanup;
             }
             if (from) {
-                snaps[snaplist->nsnaps++] = from;
+                snaplist->snaps[snaplist->nsnaps++].snap = from;
                 virDomainSnapshotRef(from);
             }
         }