I believe it was unused, so no risk was caused, but better remove it.
There's the complication that its signature has changed since libknot-2.4.0.
Fixes https://gitlab.labs.nic.cz/knot/resolver/issues/146
knot_rdata_t *knot_rdataset_at(const knot_rdataset_t *, size_t);
uint32_t knot_rrset_ttl(const knot_rrset_t *);
int knot_rrset_txt_dump_data(const knot_rrset_t *, const size_t, char *, const size_t, const knot_dump_style_t *);
-int knot_rrset_txt_dump(const knot_rrset_t *, char *, const size_t, const knot_dump_style_t *);
const knot_dname_t *knot_pkt_qname(const knot_pkt_t *);
uint16_t knot_pkt_qtype(const knot_pkt_t *);
uint16_t knot_pkt_qclass(const knot_pkt_t *);
knot_rdataset_at
knot_rrset_ttl
knot_rrset_txt_dump_data
- knot_rrset_txt_dump
# Packet
knot_pkt_qname
knot_pkt_qtype
if i ~= nil then
ret = knot.knot_rrset_txt_dump_data(rr, i, rrset_buf, rrset_buflen, knot.KNOT_DUMP_STYLE_DEFAULT)
else
- ret = knot.knot_rrset_txt_dump(rr, rrset_buf, rrset_buflen, knot.KNOT_DUMP_STYLE_DEFAULT)
+ ret = -1
end
return ret >= 0 and ffi.string(rrset_buf)
end