]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: gpio_keys - replace use of system_wq with system_dfl_wq
authorMarco Crivellari <marco.crivellari@suse.com>
Thu, 6 Nov 2025 14:19:52 +0000 (15:19 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 19 Dec 2025 04:52:47 +0000 (20:52 -0800)
Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

This specific workload do not benefit from a per-cpu workqueue, so use
the default unbound workqueue (system_dfl_wq) instead.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251106141955.218911-2-marco.crivellari@suse.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/gpio_keys.c

index f9db86da0818b24d3b6611b4d4e23c96846dbf18..5e875771a066a5b48447b3d87e862a974a5b0ea1 100644 (file)
@@ -434,7 +434,7 @@ static irqreturn_t gpio_keys_gpio_isr(int irq, void *dev_id)
                              ms_to_ktime(bdata->software_debounce),
                              HRTIMER_MODE_REL);
        } else {
-               mod_delayed_work(system_wq,
+               mod_delayed_work(system_dfl_wq,
                                 &bdata->work,
                                 msecs_to_jiffies(bdata->software_debounce));
        }