commandline: fix undefined behavior in parsing list-keywords

Flagged by clang-tidy.

diff --git a/src/suricata.c b/src/suricata.c
index 60b67f717b5eef3dd58dfbdfec6e6de7dff81a5a..dddc702b2589f7a3ddf6d0aefbb51735a5be0701 100644 (file)
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -1570,7 +1570,7 @@ TmEcode SCParseCommandLine(int argc, char **argv)
                 return TM_ECODE_OK;
             } else if (strcmp((long_opts[option_index]).name, "list-keywords") == 0) {
                 if (optarg) {
-                    if (strcmp("short",optarg)) {
+                    if (strcmp("short", optarg) != 0) {
                         suri->keyword_info = optarg;
                     }
                 }