rtc: pl030: drop needless struct pl030_rtc::rtc member

The memory pointed to by the ::rtc member is managed via devres, and
no code in this driver uses it past _probe().

We can drop it from the structure and just use a local temporary
variable, reducing runtime memory consumption by a few bytes.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-10-d4689a71668c@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c
index 1326f310bf93077b87fabe53e994219d12aced21..5caaa714f448541b54301d4c76af985e76bd80bc 100644 (file)
--- a/drivers/rtc/rtc-pl030.c
+++ b/drivers/rtc/rtc-pl030.c
@@ -21,7 +21,6 @@
 #define RTC_CR_MIE     (1 << 0)
 
 struct pl030_rtc {
-       struct rtc_device       *rtc;
        void __iomem            *base;
 };
 
@@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
 {
        struct pl030_rtc *rtc;
        int ret;
+       struct rtc_device *rtc_dev;
 
        ret = amba_request_regions(dev, NULL);
        if (ret)
@@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
                goto err_rtc;
        }
 
-       rtc->rtc = devm_rtc_allocate_device(&dev->dev);
-       if (IS_ERR(rtc->rtc)) {
-               ret = PTR_ERR(rtc->rtc);
+       rtc_dev = devm_rtc_allocate_device(&dev->dev);
+       if (IS_ERR(rtc_dev)) {
+               ret = PTR_ERR(rtc_dev);
                goto err_rtc;
        }
 
-       rtc->rtc->ops = &pl030_ops;
-       rtc->rtc->range_max = U32_MAX;
+       rtc_dev->ops = &pl030_ops;
+       rtc_dev->range_max = U32_MAX;
        rtc->base = ioremap(dev->res.start, resource_size(&dev->res));
        if (!rtc->base) {
                ret = -ENOMEM;
@@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
        if (ret)
                goto err_irq;
 
-       ret = devm_rtc_register_device(rtc->rtc);
+       ret = devm_rtc_register_device(rtc_dev);
        if (ret)
                goto err_reg;