]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Disable set eq test for python < 2.7.8
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 30 Jan 2018 20:51:30 +0000 (15:51 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 30 Jan 2018 20:52:43 +0000 (15:52 -0500)
A test added in 1.2 thought to confirm a Python 2.7 behavior turns out to
be confirming the behavior only as of Python 2.7.8. Python bug #8743 still
impacts set comparison in Python 2.7.7 and earlier, so the test in question
involving AssociationSet no longer runs for these older Python 2.7
versions.

Change-Id: I4e5ab650fdcbfd215535c58438878e98ef924a9b
Fixes: #3265
doc/build/changelog/unreleased_12/3265.rst [new file with mode: 0644]
test/ext/test_associationproxy.py
test/requirements.py

diff --git a/doc/build/changelog/unreleased_12/3265.rst b/doc/build/changelog/unreleased_12/3265.rst
new file mode 100644 (file)
index 0000000..1c97b72
--- /dev/null
@@ -0,0 +1,9 @@
+.. change::
+    :tags: bug, tests
+    :tickets: 3265
+
+    A test added in 1.2 thought to confirm a Python 2.7 behavior turns out to
+    be confirming the behavior only as of Python 2.7.8. Python bug #8743 still
+    impacts set comparison in Python 2.7.7 and earlier, so the test in question
+    involving AssociationSet no longer runs for these older Python 2.7
+    versions.
index d8fd4dc9db0f558b0dfedbbe04612b6013174189..0052bb1884114a8ae937f7e7d1d5276e582da409 100644 (file)
@@ -601,8 +601,9 @@ class SetTest(_CollectionOperations):
             self.assert_((p1.children > other) == (control > other))
             self.assert_((p1.children >= other) == (control >= other))
 
+    @testing.requires.python_fixed_issue_8743
     def test_set_comparison_empty_to_empty(self):
-        # test issue #3265 which appears to be python 2.6 specific
+        # test issue #3265 which was fixed in Python version 2.7.8
         Parent = self.Parent
 
         p1 = Parent('P1')
index f4ce0f0feb6a8c96cfd79e55e1e9ad57073897fb..d7eaec5fdbf3926a23e932a092af0fc22dec10e9 100644 (file)
@@ -1008,6 +1008,13 @@ class DefaultRequirements(SuiteRequirements):
     def no_mssql_freetds(self):
         return self.mssql_freetds.not_()
 
+    @property
+    def python_fixed_issue_8743(self):
+        return exclusions.skip_if(
+            lambda: sys.version_info < (2, 7, 8),
+            "Python issue 8743 fixed in Python 2.7.8"
+        )
+
     @property
     def selectone(self):
         """target driver must support the literal statement 'select 1'"""