]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network/tclass: make tclass_drop() static
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 2 Sep 2024 04:22:41 +0000 (13:22 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 2 Sep 2024 05:12:49 +0000 (14:12 +0900)
This also drops unused constant return value.

src/network/tc/tclass.c
src/network/tc/tclass.h

index 926ec69adf0feec03a8c1f89d76a89dea56e7827..3c74f95992ce219b12610c6de95dbd1cd4af9a54 100644 (file)
@@ -359,7 +359,7 @@ void link_tclass_drop_marked(Link *link) {
         }
 }
 
-TClass* tclass_drop(TClass *tclass) {
+static void tclass_drop(TClass *tclass) {
         assert(tclass);
 
         tclass_mark_recursive(tclass);
@@ -367,8 +367,6 @@ TClass* tclass_drop(TClass *tclass) {
         /* link_tclass_drop_marked() may invalidate tclass, so run link_qdisc_drop_marked() first. */
         link_qdisc_drop_marked(tclass->link);
         link_tclass_drop_marked(tclass->link);
-
-        return NULL;
 }
 
 static int tclass_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, TClass *tclass) {
@@ -584,7 +582,7 @@ int manager_rtnl_process_tclass(sd_netlink *rtnl, sd_netlink_message *message, M
 
         case RTM_DELTCLASS:
                 if (tclass)
-                        (void) tclass_drop(tclass);
+                        tclass_drop(tclass);
                 else
                         log_tclass_debug(tmp, link, "Kernel removed unknown");
 
index 44f71814501dc8e95d595ad95a342e9e26429523..ce51b2499ecc8e4e4e599bcd83179f5310a937e6 100644 (file)
@@ -62,7 +62,6 @@ TClass* tclass_unref(TClass *tclass);
 int tclass_new_static(TClassKind kind, Network *network, const char *filename, unsigned section_line, TClass **ret);
 
 void tclass_mark_recursive(TClass *tclass);
-TClass* tclass_drop(TClass *tclass);
 void link_tclass_drop_marked(Link *link);
 
 int link_find_tclass(Link *link, uint32_t classid, TClass **ret);