]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbindd: cm_connect_lsa_tcp() doesn't need to check for NCACN_IP_TCP or LEVEL_INT...
authorStefan Metzmacher <metze@samba.org>
Sat, 14 Sep 2024 16:54:43 +0000 (18:54 +0200)
committerJule Anger <janger@samba.org>
Thu, 12 Jun 2025 11:27:15 +0000 (11:27 +0000)
We only ever create domain->lsa_pipe_tcp with
cli_rpc_pipe_open_schannel_with_creds() and hardcoded NCACN_IP_TCP.

And schannel_update_internal returns an error with
an auth level lower than DCERPC_AUTH_LEVEL_INTEGRITY.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 61d38f70be378c59b42a6e20e7d49fea21255c6b)

source3/winbindd/winbindd_cm.c

index f33e0bcb165c659181d52500cae7b5c7cf1f4a09..9d59876970a8afc3c762e66734c37d1d16f007fe 100644 (file)
@@ -2876,9 +2876,7 @@ static NTSTATUS cm_connect_lsa_tcp(struct winbindd_domain *domain,
        /*
         * rpccli_is_connected handles more error cases
         */
-       if (rpccli_is_connected(conn->lsa_pipe_tcp) &&
-           conn->lsa_pipe_tcp->transport->transport == NCACN_IP_TCP &&
-           conn->lsa_pipe_tcp->auth->auth_level >= DCERPC_AUTH_LEVEL_INTEGRITY) {
+       if (rpccli_is_connected(conn->lsa_pipe_tcp)) {
                goto done;
        }