]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
octeontx2-af: CGX: fix bitmap leaks
authorBo Sun <bo@mboxify.com>
Fri, 6 Feb 2026 13:09:24 +0000 (21:09 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Feb 2026 03:53:05 +0000 (19:53 -0800)
The RX/TX flow-control bitmaps (rx_fc_pfvf_bmap and tx_fc_pfvf_bmap)
are allocated by cgx_lmac_init() but never freed in cgx_lmac_exit().
Unbinding and rebinding the driver therefore triggers kmemleak:

    unreferenced object (size 16):
        backtrace:
          rvu_alloc_bitmap
          cgx_probe

Free both bitmaps during teardown.

Fixes: e740003874ed ("octeontx2-af: Flow control resource management")
Cc: stable@vger.kernel.org
Signed-off-by: Bo Sun <bo@mboxify.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Jijie Shao <shaojijie@huawei.com>
Link: https://patch.msgid.link/20260206130925.1087588-2-bo@mboxify.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/cgx.c

index 42044cd810b1fa9e695c9ee08cdc06104946a842..fd4792e432bf09d1b3840f9edbb5bd0e17f4d3ed 100644 (file)
@@ -1823,6 +1823,8 @@ static int cgx_lmac_exit(struct cgx *cgx)
                cgx->mac_ops->mac_pause_frm_config(cgx, lmac->lmac_id, false);
                cgx_configure_interrupt(cgx, lmac, lmac->lmac_id, true);
                kfree(lmac->mac_to_index_bmap.bmap);
+               rvu_free_bitmap(&lmac->rx_fc_pfvf_bmap);
+               rvu_free_bitmap(&lmac->tx_fc_pfvf_bmap);
                kfree(lmac->name);
                kfree(lmac);
        }