]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpib: tnt4882: Unify *allocate_private usage
authorDominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Fri, 16 Jan 2026 17:49:23 +0000 (17:49 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2026 15:04:08 +0000 (16:04 +0100)
Use the return value of tnt4882_allocate_private in calling code as
early return value in case of error.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://patch.msgid.link/20260116174647.317256-28-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/tnt4882/tnt4882_gpib.c

index 7b9cfb6c07ad71c80667129d9ef81a844779ac2a..6d241509419ec0b732a4ad23d5ff22594cab3f4b 100644 (file)
@@ -915,8 +915,9 @@ static int ni_pci_attach(struct gpib_board *board, const struct gpib_board_confi
 
        board->status = 0;
 
-       if (tnt4882_allocate_private(board))
-               return -ENOMEM;
+       retval = tnt4882_allocate_private(board);
+       if (retval)
+               return retval;
        tnt_priv = board->private_data;
        nec_priv = &tnt_priv->nec7210_priv;
        nec_priv->type = TNT4882;
@@ -1038,8 +1039,9 @@ static int ni_isa_attach_common(struct gpib_board *board, const struct gpib_boar
 
        board->status = 0;
 
-       if (tnt4882_allocate_private(board))
-               return -ENOMEM;
+       retval = tnt4882_allocate_private(board);
+       if (retval)
+               return retval;
        tnt_priv = board->private_data;
        nec_priv = &tnt_priv->nec7210_priv;
        nec_priv->type = chipset;
@@ -1724,8 +1726,9 @@ static int ni_pcmcia_attach(struct gpib_board *board, const struct gpib_board_co
 
        board->status = 0;
 
-       if (tnt4882_allocate_private(board))
-               return -ENOMEM;
+       retval = tnt4882_allocate_private(board);
+       if (retval)
+               return retval;
 
        tnt_priv = board->private_data;
        nec_priv = &tnt_priv->nec7210_priv;