]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
ip: iplink_bridge_slave: Port over to parse_on_off()
authorPetr Machata <me@pmachata.org>
Sat, 14 Nov 2020 22:53:58 +0000 (23:53 +0100)
committerDavid Ahern <dsahern@gmail.com>
Wed, 25 Nov 2020 04:43:27 +0000 (21:43 -0700)
Invoke parse_on_off() from bridge_slave_parse_on_off() instead of
hand-rolling one. Exit on failure, because the invarg that was ivoked here
before would.

Signed-off-by: Petr Machata <me@pmachata.org>
Signed-off-by: David Ahern <dsahern@gmail.com>
ip/iplink_bridge_slave.c

index 79a1d2f5f5b8fdf1f1498d0400603ef5dcb14b94..f7f6da0c79b7c3bd04323dd18228ae8d6785ee92 100644 (file)
@@ -297,15 +297,11 @@ static void bridge_slave_print_opt(struct link_util *lu, FILE *f,
 static void bridge_slave_parse_on_off(char *arg_name, char *arg_val,
                                      struct nlmsghdr *n, int type)
 {
-       __u8 val;
-
-       if (strcmp(arg_val, "on") == 0)
-               val = 1;
-       else if (strcmp(arg_val, "off") == 0)
-               val = 0;
-       else
-               invarg("should be \"on\" or \"off\"", arg_name);
+       int ret;
+       __u8 val = parse_on_off(arg_name, arg_val, &ret);
 
+       if (ret)
+               exit(1);
        addattr8(n, 1024, type, val);
 }